Skip to content

Remove SemVersion from instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test#7142

Merged
dmathieu merged 8 commits intoopen-telemetry:mainfrom
villadalmine:deprecation#7036
Apr 7, 2025
Merged

Remove SemVersion from instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test#7142
dmathieu merged 8 commits intoopen-telemetry:mainfrom
villadalmine:deprecation#7036

Conversation

@villadalmine
Copy link
Copy Markdown
Contributor

@villadalmine villadalmine commented Apr 3, 2025

Deprecated function is removed.
Fixes #7036

@villadalmine villadalmine requested a review from a team as a code owner April 3, 2025 00:29
@villadalmine
Copy link
Copy Markdown
Contributor Author

fixes #7036

Comment thread CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (e39d588) to head (1223c4d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7142   +/-   ##
=====================================
  Coverage   75.7%   75.8%           
=====================================
  Files        207     207           
  Lines      19325   19323    -2     
=====================================
+ Hits       14648   14664   +16     
+ Misses      4244    4227   -17     
+ Partials     433     432    -1     
Files with missing lines Coverage Δ
...b.org/mongo-driver/mongo/otelmongo/test/version.go 100.0% <ø> (+40.0%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@villadalmine
Copy link
Copy Markdown
Contributor Author

@MrAlias any other changed needed to merge it ?

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Apr 7, 2025

any other changed needed to merge it ?

Yes. We require two approvals.

@dmathieu dmathieu merged commit dc2f6a3 into open-telemetry:main Apr 7, 2025
25 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SemVersion from instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test

3 participants