Skip to content

Removed DynamoDBAttributeSetter and TestDynamodbTagsCustomSetter #7128

Merged
MrAlias merged 4 commits intoopen-telemetry:mainfrom
Jivi-this-side:remove-dynamoDBAttribute
Apr 5, 2025
Merged

Removed DynamoDBAttributeSetter and TestDynamodbTagsCustomSetter #7128
MrAlias merged 4 commits intoopen-telemetry:mainfrom
Jivi-this-side:remove-dynamoDBAttribute

Conversation

@Jivi-this-side
Copy link
Copy Markdown
Contributor

@Jivi-this-side Jivi-this-side commented Apr 2, 2025

Fixed #7099

As, instructed removed DynamoDBAttributeSetter and TestDynamodbTagsCustomSetter from file and added removed entries in changelog.md file .

Thank you!

@Jivi-this-side Jivi-this-side requested a review from a team as a code owner April 2, 2025 18:20
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions Bot requested a review from akats7 April 2, 2025 18:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (3ee87ac) to head (5b61f33).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7128   +/-   ##
=====================================
  Coverage   75.8%   75.8%           
=====================================
  Files        207     207           
  Lines      19395   19393    -2     
=====================================
+ Hits       14714   14717    +3     
+ Misses      4247    4243    -4     
+ Partials     434     433    -1     
Files with missing lines Coverage Δ
...om/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go 100.0% <ø> (+1.5%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. This looks good overall. Only minor feedback on the changelog entry.

Comment thread CHANGELOG.md Outdated
@Jivi-this-side
Copy link
Copy Markdown
Contributor Author

Thank you for your valuable feedback, @MrAlias ! I have committed the changes as per your suggestions. I truly appreciate your guidance and the time you’ve taken to review my work.
Thanks again, and apologies for any inconvenience!

@MrAlias MrAlias merged commit ae71e3e into open-telemetry:main Apr 5, 2025
25 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the deprecated DynamoDBAttributeSetter function in otelaws

3 participants