Removed DynamoDBAttributeSetter and TestDynamodbTagsCustomSetter #7128
Merged
MrAlias merged 4 commits intoopen-telemetry:mainfrom Apr 5, 2025
Merged
Removed DynamoDBAttributeSetter and TestDynamodbTagsCustomSetter #7128MrAlias merged 4 commits intoopen-telemetry:mainfrom
MrAlias merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7128 +/- ##
=====================================
Coverage 75.8% 75.8%
=====================================
Files 207 207
Lines 19395 19393 -2
=====================================
+ Hits 14714 14717 +3
+ Misses 4247 4243 -4
+ Partials 434 433 -1
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Apr 3, 2025
Contributor
MrAlias
left a comment
There was a problem hiding this comment.
Thanks for this contribution. This looks good overall. Only minor feedback on the changelog entry.
Contributor
Author
|
Thank you for your valuable feedback, @MrAlias ! I have committed the changes as per your suggestions. I truly appreciate your guidance and the time you’ve taken to review my work. |
akats7
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #7099
As, instructed removed DynamoDBAttributeSetter and TestDynamodbTagsCustomSetter from file and added removed entries in changelog.md file .
Thank you!