feat(otelmux): update http.route attribute to support request.Pattern#7108
Conversation
…port for request.Pattern
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7108 +/- ##
=====================================
Coverage 80.9% 80.9%
=====================================
Files 204 204
Lines 18064 18066 +2
=====================================
+ Hits 14626 14628 +2
Misses 3011 3011
Partials 427 427
🚀 New features to boost your workflow:
|
akats7
left a comment
There was a problem hiding this comment.
Unrelated to this PR, but based on that missing test coverage, it might be good to add a test case where GetPathTemplate returns an err, maybe using a path prefix or something
I tried to cover this unit test, but because it's somewhat extreme, it's very difficult to trigger the execution that meets this part of the logic for coverage. So, I ignored it for now. |
…-setup # Conflicts: # CHANGELOG.md # instrumentation/github.com/gorilla/mux/otelmux/test/mux_test.go
|
Ready for merge. |
see #6919
Although changes have been made, I'm somewhat unsure if this is what we need. 😅