Skip to content

Remove SemVersion from instrumentation/github.com/labstack/echo/otelecho#7089

Merged
dmathieu merged 3 commits intoopen-telemetry:mainfrom
Aditya98Shukla:Issue_7038
Apr 3, 2025
Merged

Remove SemVersion from instrumentation/github.com/labstack/echo/otelecho#7089
dmathieu merged 3 commits intoopen-telemetry:mainfrom
Aditya98Shukla:Issue_7038

Conversation

@Aditya98Shukla
Copy link
Copy Markdown
Contributor

@Aditya98Shukla Aditya98Shukla commented Apr 1, 2025

Closes #7038

@Aditya98Shukla Aditya98Shukla requested a review from a team as a code owner April 1, 2025 12:30
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 1, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Aditya98Shukla (d27b458)
  • ✅ login: MrAlias / name: Tyler Yahn (252e6f0)
  • ✅ login: dmathieu / name: Damien Mathieu (3bc91d6)

@github-actions github-actions Bot requested a review from scorpionknifes April 1, 2025 12:30
@Aditya98Shukla
Copy link
Copy Markdown
Contributor Author

Closes: #7038

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (4b578bd) to head (3bc91d6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7089   +/-   ##
=====================================
  Coverage   75.8%   75.8%           
=====================================
  Files        207     207           
  Lines      19482   19480    -2     
=====================================
+ Hits       14770   14783   +13     
+ Misses      4276    4261   -15     
  Partials     436     436           
Files with missing lines Coverage Δ
...ation/github.com/labstack/echo/otelecho/version.go 100.0% <ø> (+40.0%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit 5dfac72 into open-telemetry:main Apr 3, 2025
25 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SemVersion from instrumentation/github.com/labstack/echo/otelecho

3 participants