Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6961 +/- ##
=======================================
- Coverage 81.5% 81.5% -0.1%
=======================================
Files 199 200 +1
Lines 18065 18129 +64
=======================================
+ Hits 14741 14793 +52
- Misses 2927 2938 +11
- Partials 397 398 +1
🚀 New features to boost your workflow:
|
dmathieu
left a comment
There was a problem hiding this comment.
Since this is its own go.mod (as it should be), we should add an entry in CODEOWNERS.
|
|
||
| // Version is the current release version of the EC2 resource detector. | ||
| func Version() string { | ||
| return "1.35.0" |
There was a problem hiding this comment.
Let's make this unstable first (which makes the version 0.60.0)
There was a problem hiding this comment.
Let's not release this until we want it stabilized. Having a v2 package at a major version of less than 2 is incongruent. The package can be referenced via a commit hash until we want it stabilized.
|
@open-telemetry/go-approvers Do we want to merge this in the near future, the EOL date for the v1 sdk is 7/31 |
PR for V2 of EC2 detector, due to deprecation of aws-sdk-go