Skip to content

otelrestful: use semconv package for request attributes and span status#6951

Merged
XSAM merged 7 commits into
open-telemetry:mainfrom
dmathieu:otelrestful-remove-semconvutil
Apr 16, 2025
Merged

otelrestful: use semconv package for request attributes and span status#6951
XSAM merged 7 commits into
open-telemetry:mainfrom
dmathieu:otelrestful-remove-semconvutil

Conversation

@dmathieu
Copy link
Copy Markdown
Member

We missed this use of semconvutil which we need to remove to be able to finalize the semconv migration.

I chose not to add a changelog entry here because there is technically no visible change, since the default is still to use the old semantic conventions only.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Mar 18, 2025
@github-actions github-actions Bot requested a review from dashpole March 18, 2025 08:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.0%. Comparing base (216875f) to head (0486a84).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6951   +/-   ##
=====================================
  Coverage   80.9%   81.0%           
=====================================
  Files        204     204           
  Lines      18065   18065           
=====================================
+ Hits       14627   14633    +6     
+ Misses      3011    3005    -6     
  Partials     427     427           
Files with missing lines Coverage Δ
...hub.com/emicklei/go-restful/otelrestful/restful.go 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review March 18, 2025 08:32
@dmathieu dmathieu requested a review from a team as a code owner March 18, 2025 08:32
@dmathieu dmathieu requested a review from XSAM March 26, 2025 10:03
@dmathieu
Copy link
Copy Markdown
Member Author

dmathieu commented Apr 9, 2025

cc @XSAM for review.

@dmathieu dmathieu added this to the v1.36.0 milestone Apr 16, 2025
@XSAM XSAM merged commit 064267a into open-telemetry:main Apr 16, 2025
28 checks passed
@dmathieu dmathieu deleted the otelrestful-remove-semconvutil branch April 16, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants