otelrestful: use semconv package for request attributes and span status#6951
Merged
XSAM merged 7 commits intoApr 16, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6951 +/- ##
=====================================
Coverage 80.9% 81.0%
=====================================
Files 204 204
Lines 18065 18065
=====================================
+ Hits 14627 14633 +6
+ Misses 3011 3005 -6
Partials 427 427
🚀 New features to boost your workflow:
|
pellared
approved these changes
Mar 25, 2025
Member
Author
|
cc @XSAM for review. |
XSAM
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed this use of semconvutil which we need to remove to be able to finalize the semconv migration.
I chose not to add a changelog entry here because there is technically no visible change, since the default is still to use the old semantic conventions only.