Skip to content

Address GO-2025-3487#6852

Closed
XSAM wants to merge 4 commits intoopen-telemetry:mainfrom
XSAM:GO-2025-3487
Closed

Address GO-2025-3487#6852
XSAM wants to merge 4 commits intoopen-telemetry:mainfrom
XSAM:GO-2025-3487

Conversation

@XSAM
Copy link
Copy Markdown
Member

@XSAM XSAM commented Feb 27, 2025

Fix https://pkg.go.dev/vuln/GO-2025-3487 by bump golang.org/x/crypto to v0.35.0

Waiting for #6853 to be merged to prevent generating the toolchain directive in go mod. It seems go mod tidy would add the toolchain directive if the go directive is needed to be changed. And, the golang.org/x/crypto:v0.35.0 needs Go 1.23. https://cs.opensource.google/go/x/crypto/+/master:go.mod;l=3


After #6853 is merged, it is now good. No more automatic added go directive after go mod tidy. Not sure if it is a bug of Go or not 🤷‍♂️.

@XSAM XSAM added this to the v1.35.0 milestone Feb 27, 2025
@pellared pellared removed this from the v1.35.0 milestone Feb 27, 2025
@XSAM XSAM added this to the v1.36.0 milestone Feb 27, 2025
@XSAM XSAM marked this pull request as ready for review March 6, 2025 07:38
@XSAM XSAM requested a review from a team as a code owner March 6, 2025 07:38
@XSAM XSAM added Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG and removed Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Mar 6, 2025
@pellared
Copy link
Copy Markdown
Member

pellared commented Mar 6, 2025

I am not sure if we need a changelog for it.
govulncheck has not detected that we are calling the vulnerable code.
I think we can simply supersede this PR with #6829.
Thoughts?

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Mar 6, 2025

I agree we don't need a changelog. We also wouldn't have created one if this had been opened by renovate.

@pellared
Copy link
Copy Markdown
Member

pellared commented Mar 6, 2025

#6829 is merged

@pellared pellared closed this Mar 6, 2025
@XSAM XSAM deleted the GO-2025-3487 branch March 6, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants