Skip to content

refactor(otelgin): refactor HTTP server attributes to use new semconv package#6778

Merged
dmathieu merged 9 commits into
open-telemetry:mainfrom
flc1125:otelgin-replace-semconv
Feb 14, 2025
Merged

refactor(otelgin): refactor HTTP server attributes to use new semconv package#6778
dmathieu merged 9 commits into
open-telemetry:mainfrom
flc1125:otelgin-replace-semconv

Conversation

@flc1125
Copy link
Copy Markdown
Member

@flc1125 flc1125 commented Feb 13, 2025

closed #6764

@flc1125
Copy link
Copy Markdown
Member Author

flc1125 commented Feb 13, 2025

This PR has some duplicated (conflicting) content with #6747, and I'm resolving the conflicts after one of them is merged.

@github-actions github-actions Bot requested a review from akats7 February 13, 2025 15:02
@flc1125 flc1125 marked this pull request as ready for review February 13, 2025 15:02
@flc1125 flc1125 requested a review from a team as a code owner February 13, 2025 15:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5%. Comparing base (3d62c25) to head (65846f6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6778   +/-   ##
=====================================
  Coverage   75.5%   75.5%           
=====================================
  Files        207     207           
  Lines      19149   19152    +3     
=====================================
+ Hits       14461   14475   +14     
+ Misses      4253    4241   -12     
- Partials     435     436    +1     
Files with missing lines Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 92.4% <100.0%> (+0.1%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Copy Markdown
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this gin has been missed here because there was no issue. I think there were none because the package was in the process of being removed when we planned the migration work.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@flc1125
Copy link
Copy Markdown
Member Author

flc1125 commented Feb 14, 2025

I realize this gin has been missed here because there was no issue. I think there were none because the package was in the process of being removed when we planned the migration work.

otelhttp is designed so well that gin can switch to the new one very quickly.

…conv

# Conflicts:
#	instrumentation/github.com/gin-gonic/gin/otelgin/gintrace.go
@dmathieu dmathieu merged commit 8b5220b into open-telemetry:main Feb 14, 2025
@flc1125 flc1125 deleted the otelgin-replace-semconv branch February 18, 2025 02:04
@XSAM XSAM added this to the v1.35.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(otelgin): replace direct semconv usage with internal semconv package

4 participants