config: fix issue causing a crash on invalid value#6752
Merged
dmathieu merged 3 commits intoFeb 12, 2025
Conversation
This addresses a bug that was uncovered in the collector after updating to the latest version of `config` where an unset value in the `NameStringValuePair` results in a nil dereferencing. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6752 +/- ##
=====================================
Coverage 75.1% 75.1%
=====================================
Files 203 203
Lines 18322 18323 +1
=====================================
+ Hits 13768 13775 +7
+ Misses 4144 4140 -4
+ Partials 410 408 -2
|
dmathieu
approved these changes
Feb 11, 2025
mx-psi
approved these changes
Feb 11, 2025
dashpole
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug that was uncovered in the collector after updating to the latest version of
configwhere an unset value in theNameStringValuePairresults in a nil dereferencing.