Skip to content

Use semconv package for otelrestful#6710

Merged
dmathieu merged 8 commits into
open-telemetry:mainfrom
dmathieu:semconv-otelrestful
Feb 7, 2025
Merged

Use semconv package for otelrestful#6710
dmathieu merged 8 commits into
open-telemetry:mainfrom
dmathieu:semconv-otelrestful

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Feb 4, 2025

This switches otelrestful to use the semconv internal package, so it can migrate to stable HTTP semconv attributes.

Closes #6639

@github-actions github-actions Bot requested a review from dashpole February 4, 2025 10:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 87.78338% with 97 lines in your changes missing coverage. Please review.

Project coverage is 75.1%. Comparing base (d21dd87) to head (c711f43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...o-restful/otelrestful/internal/semconv/httpconv.go 86.0% 42 Missing and 15 partials ⚠️
...go-restful/otelrestful/internal/semconv/v1.20.0.go 89.9% 11 Missing and 7 partials ⚠️
...lei/go-restful/otelrestful/internal/semconv/env.go 89.1% 15 Missing and 1 partial ⚠️
...ei/go-restful/otelrestful/internal/semconv/util.go 89.4% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6710     +/-   ##
=======================================
+ Coverage   74.5%   75.1%   +0.5%     
=======================================
  Files        199     203      +4     
  Lines      17529   18322    +793     
=======================================
+ Hits       13075   13771    +696     
- Misses      4070    4142     +72     
- Partials     384     409     +25     
Files with missing lines Coverage Δ
...hub.com/emicklei/go-restful/otelrestful/restful.go 100.0% <100.0%> (ø)
...ei/go-restful/otelrestful/internal/semconv/util.go 89.4% <89.4%> (ø)
...lei/go-restful/otelrestful/internal/semconv/env.go 89.1% <89.1%> (ø)
...go-restful/otelrestful/internal/semconv/v1.20.0.go 89.9% <89.9%> (ø)
...o-restful/otelrestful/internal/semconv/httpconv.go 86.0% <86.0%> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu marked this pull request as ready for review February 4, 2025 10:39
@dmathieu dmathieu requested a review from a team as a code owner February 4, 2025 10:39
@MrAlias MrAlias added this to the v1.35.0 milestone Feb 6, 2025
@dmathieu dmathieu merged commit 39ffca8 into open-telemetry:main Feb 7, 2025
@dmathieu dmathieu deleted the semconv-otelrestful branch February 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Migrate to semconv for otelrestful

3 participants