Skip to content

config: add support for Insecure#6658

Merged
dmathieu merged 6 commits into
open-telemetry:mainfrom
mattsains:insecure
Feb 5, 2025
Merged

config: add support for Insecure#6658
dmathieu merged 6 commits into
open-telemetry:mainfrom
mattsains:insecure

Conversation

@mattsains
Copy link
Copy Markdown
Contributor

@mattsains mattsains commented Jan 21, 2025

@mattsains mattsains requested review from a team and pellared as code owners January 21, 2025 20:24
@github-actions github-actions Bot requested a review from codeboten January 21, 2025 20:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (8129e89) to head (3210496).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6658   +/-   ##
=====================================
  Coverage   73.9%   73.9%           
=====================================
  Files        195     195           
  Lines      16671   16671           
=====================================
  Hits       12332   12332           
  Misses      3980    3980           
  Partials     359     359           
Files with missing lines Coverage Δ
config/v0.3.0/log.go 95.3% <100.0%> (ø)
config/v0.3.0/metric.go 89.0% <100.0%> (ø)
config/v0.3.0/trace.go 97.3% <100.0%> (ø)

... and 1 file with indirect coverage changes

Comment thread config/v0.3.0/log.go
@pellared
Copy link
Copy Markdown
Member

@codeboten, PTAL as a codeowner

Comment thread config/v0.3.0/log.go
@mattsains
Copy link
Copy Markdown
Contributor Author

@codeboten I think I need your approval to get this PR to merged

@dmathieu dmathieu merged commit beb885f into open-telemetry:main Feb 5, 2025
@MrAlias MrAlias added this to the v1.35.0 milestone Feb 6, 2025
@mattsains mattsains deleted the insecure branch February 10, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otlpHTTPLogExporter, otlpGRPCLogExporter, etc do not support fields like OTLP.Certificate

5 participants