Skip to content

config: support HeadersList#6657

Merged
pellared merged 11 commits into
open-telemetry:mainfrom
mattsains:headerslist
Feb 18, 2025
Merged

config: support HeadersList#6657
pellared merged 11 commits into
open-telemetry:mainfrom
mattsains:headerslist

Conversation

@mattsains
Copy link
Copy Markdown
Contributor

@mattsains mattsains commented Jan 21, 2025

Fixes #6351

@mattsains mattsains requested review from a team and pellared as code owners January 21, 2025 20:04
@github-actions github-actions Bot requested a review from codeboten January 21, 2025 20:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.6%. Comparing base (764a633) to head (c5dafcb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6657   +/-   ##
=====================================
  Coverage   75.5%   75.6%           
=====================================
  Files        207     207           
  Lines      19152   19186   +34     
=====================================
+ Hits       14475   14506   +31     
- Misses      4241    4243    +2     
- Partials     436     437    +1     
Files with missing lines Coverage Δ
config/v0.3.0/config.go 89.7% <100.0%> (+1.1%) ⬆️
config/v0.3.0/log.go 95.5% <100.0%> (+0.2%) ⬆️
config/v0.3.0/metric.go 89.2% <100.0%> (+0.2%) ⬆️
config/v0.3.0/trace.go 97.4% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

@pellared
Copy link
Copy Markdown
Member

@codeboten, PTAL as a codeowner

Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating these two files:

  • config/testdata/v0.3.yaml
  • config/testdata/v0.3.json

so that they include the new supported fields?

Comment thread config/v0.3.0/config.go Outdated
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@mattsains
Copy link
Copy Markdown
Contributor Author

How about updating these two files:

  • config/testdata/v0.3.yaml
  • config/testdata/v0.3.json

so that they include the new supported fields?

They already are in the config files but so far have been unsupported by the code. That’s what inspired me to create this PR in the first place

@pellared
Copy link
Copy Markdown
Member

Looks goods 👍 Please resolve the conflicts.

Comment thread config/v0.3.0/config.go
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattsains!

Comment thread config/v0.3.0/config.go
@pellared pellared added this to the v1.35.0 milestone Feb 18, 2025
@pellared pellared merged commit 6e7414f into open-telemetry:main Feb 18, 2025
@mattsains mattsains deleted the headerslist branch February 18, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otlpHTTPLogExporter, otlpGRPCLogExporter, etc do not support fields like OTLP.Certificate

4 participants