config: support HeadersList#6657
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6657 +/- ##
=====================================
Coverage 75.5% 75.6%
=====================================
Files 207 207
Lines 19152 19186 +34
=====================================
+ Hits 14475 14506 +31
- Misses 4241 4243 +2
- Partials 436 437 +1
|
dmathieu
approved these changes
Jan 22, 2025
Member
|
@codeboten, PTAL as a codeowner |
pellared
reviewed
Feb 17, 2025
Member
pellared
left a comment
There was a problem hiding this comment.
How about updating these two files:
config/testdata/v0.3.yamlconfig/testdata/v0.3.json
so that they include the new supported fields?
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Contributor
Author
They already are in the config files but so far have been unsupported by the code. That’s what inspired me to create this PR in the first place |
pellared
approved these changes
Feb 17, 2025
Member
|
Looks goods 👍 Please resolve the conflicts. |
pellared
reviewed
Feb 18, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6351