Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable usestdlibvars linter #6367

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

usestdlibvars is a linter that detect the possibility to use variables/constants from the Go standard library.

@mmorel-35 mmorel-35 requested review from dmathieu and a team as code owners November 24, 2024 17:01
@github-actions github-actions bot requested a review from pyohannes November 24, 2024 17:01
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.9%. Comparing base (9d3f756) to head (8f0fc3f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...p/httptrace/otelhttptrace/example/client/client.go 0.0% 1 Missing ⚠️
...ntation/net/http/otelhttp/example/client/client.go 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6367   +/-   ##
=====================================
  Coverage   66.9%   66.9%           
=====================================
  Files        193     193           
  Lines      15652   15652           
=====================================
+ Hits       10480   10483    +3     
+ Misses      4881    4879    -2     
+ Partials     291     290    -1     
Files with missing lines Coverage Δ
detectors/azure/azurevm/vm.go 90.7% <100.0%> (ø)
instrumentation/net/http/otelhttp/client.go 57.1% <100.0%> (ø)
...p/httptrace/otelhttptrace/example/client/client.go 0.0% <0.0%> (ø)
...ntation/net/http/otelhttp/example/client/client.go 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

.golangci.yml Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 force-pushed the golangci-lint/usestdlibvars branch from 0dcfc10 to ebf5926 Compare November 25, 2024 12:02
@dmathieu dmathieu merged commit 31fe1e4 into open-telemetry:main Nov 25, 2024
23 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/usestdlibvars branch November 25, 2024 17:54
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants