-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otellogr: Implement Error and comment Init #6295
Merged
dmathieu
merged 9 commits into
open-telemetry:main
from
scorpionknifes:otellogr/implement-error
Nov 14, 2024
Merged
otellogr: Implement Error and comment Init #6295
dmathieu
merged 9 commits into
open-telemetry:main
from
scorpionknifes:otellogr/implement-error
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
=====================================
Coverage 66.7% 66.8%
=====================================
Files 193 193
Lines 15565 15580 +15
=====================================
+ Hits 10391 10414 +23
+ Misses 4883 4877 -6
+ Partials 291 289 -2
|
dmathieu
reviewed
Nov 6, 2024
scorpionknifes
added
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
bridge: logr
Related to the logr bridge
labels
Nov 13, 2024
dmathieu
approved these changes
Nov 14, 2024
You need to run |
pellared
reviewed
Nov 14, 2024
pellared
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bridge: logr
Related to the logr bridge
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements remaining methods and adds to the changelog
Part of #5192