Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otellogr: Implement Error and comment Init #6295

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

scorpionknifes
Copy link
Member

@scorpionknifes scorpionknifes commented Nov 5, 2024

Implements remaining methods and adds to the changelog

Part of #5192

@scorpionknifes scorpionknifes requested review from pellared and a team as code owners November 5, 2024 23:09
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (f9d4025) to head (29fa319).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6295   +/-   ##
=====================================
  Coverage   66.7%   66.8%           
=====================================
  Files        193     193           
  Lines      15565   15580   +15     
=====================================
+ Hits       10391   10414   +23     
+ Misses      4883    4877    -6     
+ Partials     291     289    -2     
Files with missing lines Coverage Δ
bridges/otellogr/logsink.go 100.0% <100.0%> (+1.8%) ⬆️

... and 1 file with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
bridges/otellogr/logsink.go Outdated Show resolved Hide resolved
@scorpionknifes scorpionknifes added Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG bridge: logr Related to the logr bridge labels Nov 13, 2024
@dmathieu
Copy link
Member

You need to run go mod tidy.

@dmathieu dmathieu merged commit 5b9cf72 into open-telemetry:main Nov 14, 2024
25 checks passed
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: logr Related to the logr bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants