Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xray sampler #6187

Merged
merged 6 commits into from
Oct 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Fixed

- Possible nil dereference panic in `go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace`. (#5965)
- Non-200 HTTP status codes when retrieving sampling rules in `go.opentelemetry.io/contrib/samplers/aws/xray` now return an error. (#5718)

### Removed

- The `Minimum` field of the `LogProcessor` in `go.opentelemetry.io/contrib/processors/minsev` is removed.
Use `NewLogProcessor` to configure this setting. (#6116)
- The deprecated `go.opentelemetry.io/contrib/samplers/aws/xray` package is removed. (#6187)

<!-- Released section -->
<!-- Don't change this section unless doing release -->
Expand Down
1 change: 0 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ propagators/jaeger/ @open-te
propagators/opencensus/ @open-telemetry/go-approvers @dashpole
propagators/ot/ @open-telemetry/go-approvers @pellared

samplers/aws/xray/ @open-telemetry/go-approvers
samplers/jaegerremote/ @open-telemetry/go-approvers @yurishkuro
samplers/probability/consistent/ @open-telemetry/go-approvers

Expand Down
91 changes: 0 additions & 91 deletions samplers/aws/xray/fallback_sampler.go

This file was deleted.

63 changes: 0 additions & 63 deletions samplers/aws/xray/fallback_sampler_test.go

This file was deleted.

22 changes: 0 additions & 22 deletions samplers/aws/xray/go.mod

This file was deleted.

29 changes: 0 additions & 29 deletions samplers/aws/xray/go.sum

This file was deleted.

Loading
Loading