Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove otelmacaron #6186

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Remove otelmacaron #6186

merged 6 commits into from
Oct 10, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 3, 2024

Resolve #5552

This package was deprecated in release v0.53.0 on 2024-07-03. It is no longer supported and is being removed.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.5%. Comparing base (87d0229) to head (44c0257).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6186     +/-   ##
=======================================
- Coverage   67.2%   66.5%   -0.7%     
=======================================
  Files        194     187      -7     
  Lines      12766   12344    -422     
=======================================
- Hits        8584    8214    -370     
+ Misses      3904    3857     -47     
+ Partials     278     273      -5     

see 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review October 3, 2024 20:22
@MrAlias MrAlias requested review from a team, pellared, dashpole, XSAM and dmathieu as code owners October 3, 2024 20:22
@pellared pellared added this to the v1.31.0 milestone Oct 4, 2024
@MrAlias MrAlias merged commit 5322670 into open-telemetry:main Oct 10, 2024
23 of 24 checks passed
@MrAlias MrAlias deleted the rm-otelmacaron branch October 10, 2024 16:47
MrAlias added a commit that referenced this pull request Oct 14, 2024
### Added

- The `Severitier` and `SeverityVar` types are added to
`go.opentelemetry.io/contrib/processors/minsev` allowing dynamic
configuration of the severity used by the `LogProcessor`. (#6116)
- Move examples from `go.opentelemetry.io/otel` to this repository under
`examples` directory. (#6158)
- Support yaml/json struct tags for generated code in
`go.opentelemetry.io/contrib/config`. (#5433)
- Add support for parsing YAML configuration via `ParseYAML` in
`go.opentelemetry.io/contrib/config`. (#5433)
- Add support for temporality preference configuration in
`go.opentelemetry.io/contrib/config`. (#5860)

### Changed

- The function signature of `NewLogProcessor` in
`go.opentelemetry.io/contrib/processors/minsev` has changed to accept
the added `Severitier` interface instead of a `log.Severity`. (#6116)
- Updated `go.opentelemetry.io/contrib/config` to use the
[v0.3.0](https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v0.3.0)
release of schema which includes backwards incompatible changes. (#6126)
- `NewSDK` in `go.opentelemetry.io/contrib/config` now returns a no-op
SDK if `disabled` is set to `true`. (#6185)
- The deprecated
`go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho`
package has found a Code Owner. The package is no longer deprecated.
(#6207)

### Fixed

- Possible nil dereference panic in
`go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace`.
(#5965)
- `logrus.Level` transformed to appropriate `log.Severity` in
`go.opentelemetry.io/contrib/bridges/otellogrus`. (#6191)

### Removed

- The `Minimum` field of the `LogProcessor` in
`go.opentelemetry.io/contrib/processors/minsev` is removed.
  Use `NewLogProcessor` to configure this setting. (#6116)
- The deprecated
`go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron`
package is removed. (#6186)
- The deprecated `go.opentelemetry.io/contrib/samplers/aws/xray` package
is removed. (#6187)

---------

Co-authored-by: David Ashpole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron
4 participants