Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove incorrect comment #6090

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

codeboten
Copy link
Contributor

The issue to return the SDK was implemented but the TODO was left behind. Removing it in this PR.

The issue to return the SDK was implemented but the TODO was left behind. Removing it in this PR.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team September 5, 2024 20:17
@dashpole dashpole added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 5, 2024
@codeboten
Copy link
Contributor Author

😅 Almost certain that my change didnt cause:

govulncheck: fetching vulnerabilities: HTTP GET https://vuln.go.dev/ID/GO-2022-0965.json.gz returned unexpected status: 503 Service Unavailable

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.7%. Comparing base (8a49875) to head (5493a75).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6090   +/-   ##
=====================================
  Coverage   65.7%   65.7%           
=====================================
  Files        203     203           
  Lines      13037   13037           
=====================================
  Hits        8568    8568           
  Misses      4206    4206           
  Partials     263     263           
Files with missing lines Coverage Δ
config/config.go 82.2% <ø> (ø)

@pellared pellared merged commit e041295 into open-telemetry:main Sep 9, 2024
27 checks passed
@XSAM XSAM added this to the v1.30.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants