XRay Remote Sampler - Preserve previous rule reservoir if rule property has not changed #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
reviewed
Mar 23, 2023
|
Could you add tests? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3620 +/- ##
=====================================
Coverage 70.4% 70.5%
=====================================
Files 149 149
Lines 7123 7133 +10
=====================================
+ Hits 5020 5030 +10
Misses 1972 1972
Partials 131 131
|
|
@Aneurysm9 Pinging for review! |
Aneurysm9
approved these changes
Apr 25, 2023
dmathieu
approved these changes
Apr 27, 2023
|
@Aneurysm9 @dmathieu |
Aneurysm9
reviewed
May 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #3619
Issue summary: When Sampling Rules are updated, the previous rule reservoir is removed, which will take away any sampling quota from the user. When Rules are updated very frequently, the reservoir is removed frequently. The previous rule should be preserved if the rule property hasn't changed.
FIx:
When updating Rules, if the new
Rule.rulePropertieshasn't changed, then preserve the previous Rule (which will also preserve the Rule reservoir and Rule samplingStatistics).