Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Change runtime.uptime instrument from Int64ObservableUpDownCounter to Int64ObservableCounter #3347

Merged
merged 2 commits into from
Feb 3, 2023
Merged

[runtime] Change runtime.uptime instrument from Int64ObservableUpDownCounter to Int64ObservableCounter #3347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd2a170
Change runtime.uptime instrument from up down counter to counter
matej-g Jan 31, 2023
74b9ca4
Update CHANGELOG
matej-g Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- Add the new `go.opentelemetry.io/contrib/instrgen` package to provide auto-generated source code instrumentation. (#3068)

### Changed
- Change `runtime.uptime` instrument in `go.opentelemetry.io/contrib/instrumentation/runtime` from `Int64ObservableUpDownCounter` to `Int64ObservableCounter`,
since the value is monotonic. (#3347)

## [1.13.0/0.37.0/0.7.0] - 2023-01-30

### Added
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/runtime/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func Start(opts ...Option) error {

func (r *runtime) register() error {
startTime := time.Now()
uptime, err := r.meter.Int64ObservableUpDownCounter(
uptime, err := r.meter.Int64ObservableCounter(
"runtime.uptime",
instrument.WithUnit(unit.Milliseconds),
instrument.WithDescription("Milliseconds since application was initialized"),
Expand Down