Avoid getting a new Tracer for every RPC#2835
Merged
Merged
Conversation
bogdandrutu
requested review from
Aneurysm9,
MadVikingGod,
MrAlias,
XSAM,
dashpole,
dmathieu,
evantorrie,
hanyuancheung,
jmacd and
pellared
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
=====================================
Coverage 69.4% 69.4%
=====================================
Files 145 145
Lines 6712 6712
=====================================
Hits 4660 4660
Misses 1938 1938
Partials 114 114
|
MrAlias
approved these changes
Oct 5, 2022
Aneurysm9
approved these changes
Oct 6, 2022
Member
Aneurysm9
left a comment
Aneurysm9
left a comment
There was a problem hiding this comment.
Please add a changelog entry. While this should be transparent to users, it could have impact (hopefully just positive performance impact) and they should be made aware.
dmathieu
approved these changes
Oct 6, 2022
dashpole
approved these changes
Oct 6, 2022
bogdandrutu
force-pushed
the
avoidtracer
branch
from
f258c1c to
01bd3e7
Compare
bogdandrutu
changed the title
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
avoidtracer
branch
from
01bd3e7 to
c8a5eda
Compare
This was referenced Oct 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@open-telemetry/go-approvers I believe you should do this optimization for all your instrumentations, since it does not make any sense to retrieve a new Tracer (with same arguments) every request.