Support proto v2 message format, drop v1 format#2647
Merged
Conversation
ash2k
requested review from
Aneurysm9,
MadVikingGod,
MrAlias,
XSAM,
dashpole,
dmathieu,
evantorrie,
hanyuancheung,
jmacd and
pellared
as code owners
jmacd
approved these changes
Sep 19, 2022
dmathieu
approved these changes
Sep 20, 2022
Aneurysm9
approved these changes
Oct 7, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
=====================================
Coverage 69.2% 69.2%
=====================================
Files 145 145
Lines 6709 6712 +3
=====================================
+ Hits 4648 4651 +3
Misses 1947 1947
Partials 114 114
|
Member
Author
|
Rebased to resolve conflicts. Ready for merge. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1028.
Currently, the size is only calculated for v1 messages and not for v2. This is because type assertion checks for the v1 interface.
We have two options:
This PR proposes to drop v1 support as the API has been deprecated for quite a while and most users should have migrated to v2 already. This should fix the performance problem by never calculating the size for v1 messages. Instead, the size will be efficiently calculated for v2 messages.