Move config validate#897
Merged
Merged
Conversation
florianl
requested changes
Oct 29, 2025
florianl
reviewed
Nov 4, 2025
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
…ebpf-profiler into move-config-validate
florianl
reviewed
Nov 5, 2025
Member
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
Thanks for the update. Can you resolve also the merge conflict?
| "runtime" | ||
| "time" | ||
|
|
||
| "go.opentelemetry.io/collector/confmap/xconfmap" |
Member
There was a problem hiding this comment.
It seems like with the import of this dependency we increase the binary size from 30108535 bytes (for commit e413d8c on main) to 30929253 bytes (for commit f6f355b on this branch). Resulting in an increase of ~0.8 MB.
As xconfmap is used only for the compile time check, can we work around this in some other way?
Contributor
Author
There was a problem hiding this comment.
I have removed this type assertion as this is also tested by this unit test.
…ebpf-profiler into move-config-validate
This reverts commit 4cb8b3a.
florianl
approved these changes
Nov 6, 2025
rogercoll
approved these changes
Nov 7, 2025
christos68k
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
controller.Config.Validatecontent toconfig.Config.Validate.This is a split of #859 where the goal is to implement Validate on the config without code duplication. See #849 (comment) for more context.