Skip to content

Validate the controller config. #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ogaca-dd wants to merge 5 commits into from
Closed

Validate the controller config. #849

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
588b902
Add an options to validate the controller config.
ogaca-dd Oct 2, 2025
18bcc65
Add a bool to WithConfigValidation
ogaca-dd Oct 2, 2025
b3d72a1
Always validate the config
ogaca-dd Oct 3, 2025
cd69654
Add a unit test for config validation
ogaca-dd Oct 6, 2025
af5d5d8
Remvove InvalidSamplingFrequencyError
ogaca-dd Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion collector/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ func BuildProfilesReceiver(options ...option) xreceiver.CreateProfilesFunc {
ExecutableReporter: controllerOption.executableReporter,
OnShutdown: controllerOption.onShutdown,
}

err := controlerCfg.Validate()
Comment thread
dmathieu marked this conversation as resolved.
if err != nil {
return nil, err
}
return internal.NewController(controlerCfg, rs, nextConsumer)
}
}
Expand Down