Make Go label collection work for stripped binaries#729
Closed
nsavoire wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Make Go label collection work for stripped binaries#729nsavoire wants to merge 1 commit intoopen-telemetry:mainfrom
nsavoire wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Use gopclntab to retrieve the runtime.stackcheck / runtime.load_g symbol address when the binary is stripped. Symbol lookup is currently implemented inefficiently by iterating over the gopclntab functions.
|
florianl
reviewed
Aug 25, 2025
| return p.val, true | ||
| } | ||
|
|
||
| func (g *Gopclntab) LookupFunction(funcName string) (uintptr, error) { |
Contributor
Author
There was a problem hiding this comment.
Sorry about that, I did not see you already opened a PR for this. I will close this one...
Member
There was a problem hiding this comment.
no worry :) it was just pushed earlier this morning.
nsavoire
deleted the
nsavoire/g_offset_retrieval_for_stripped_binaries
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use gopclntab to retrieve the runtime.stackcheck / runtime.load_g symbol address when the binary is stripped.
Symbol lookup is currently implemented inefficiently by iterating over the gopclntab functions.