Skip to content

reporter: drop HostMetadataReporter#717

Merged
fabled merged 2 commits intomainfrom
reporter-hostmetadata
Aug 21, 2025
Merged

reporter: drop HostMetadataReporter#717
fabled merged 2 commits intomainfrom
reporter-hostmetadata

Conversation

@florianl
Copy link
Copy Markdown
Member

With HostMetadataReporter host specific attributes were reported in the past. Remove this interface, as this is no longer the case and the interface just allocates memory without using it.

With HostMetadataReporter host specific attributes were reported in the past. Remove this interface, as this is no longer the case and the interface just allocates memory without using it.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested review from a team as code owners August 21, 2025 06:05
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl
Copy link
Copy Markdown
Member Author

@brancz or @Gandem - please let me know, if you rely on this interface and removing it will cause issues for you.

@Gandem
Copy link
Copy Markdown
Member

Gandem commented Aug 21, 2025

On our side we do not, thanks for double checking 🙏 !

@brancz
Copy link
Copy Markdown
Contributor

brancz commented Aug 21, 2025

Unused by us as well, thank you for checking!

@fabled fabled merged commit 61b90b5 into main Aug 21, 2025
28 checks passed
@fabled fabled deleted the reporter-hostmetadata branch August 21, 2025 16:38
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request Sep 30, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants