tools/zstpak: name file in error message#713
Merged
christos68k merged 2 commits intomainfrom Aug 20, 2025
Merged
Conversation
If coredump tests fail because of a file with an unexected format, we get the following error: ``` failed to open coredump file reader: failed to open local file: file doesn't appear to be in zstpak format (bad magic) ``` Enrich the returned error message with the file name, to help debug this issue. Now it looks like this: ``` failed to open coredump file reader: failed to open local file: modulecache/09d5bc25045e77dd69e76304b8babc5b0bc85abda959a8c65cd3a3d9b471bdd0: file doesn't appear to be in zstpak format (bad magic) ``` Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
fabled
reviewed
Aug 20, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
fabled
approved these changes
Aug 20, 2025
christos68k
approved these changes
Aug 20, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 30, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If coredump tests fail because of a file with an unexected format, we get the following error:
Enrich the returned error message with the file name, to help debug this issue. Now it looks like this: