golabels: Remove -C flag from golabels test build commands#699
Merged
christos68k merged 1 commit intoopen-telemetry:mainfrom Aug 14, 2025
Merged
golabels: Remove -C flag from golabels test build commands#699christos68k merged 1 commit intoopen-telemetry:mainfrom
christos68k merged 1 commit intoopen-telemetry:mainfrom
Conversation
gnurizen
force-pushed
the
fix-golabels-tests
branch
from
5e5aeb7 to
d676180
Compare
The -C flag was causing the test binaries to be created in the wrong directory (./interpreter/golabels/integrationtests/support/ instead of ./support/). This fix removes the -C flag and uses the package path directly, ensuring the binaries are created in the correct location.
gnurizen
changed the title
florianl
approved these changes
Aug 14, 2025
Member
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
sorry that I mixed arguments to go test.
christos68k
approved these changes
Aug 14, 2025
Contributor
Author
|
No problem, thanks for the quick merge guys! |
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -C flag was causing the test binaries to be created in the wrong directory
(./interpreter/golabels/integrationtests/support/ instead of ./support/).
This fix removes the -C flag and uses the package path directly, ensuring
the binaries are created in the correct location.