Remove host.FileID from StackDeltaProvider interface#664
Merged
fabled merged 1 commit intoopen-telemetry:mainfrom Jul 31, 2025
Merged
Conversation
No one uses this. It was originally envisioned to be used for possibly implementing alternative provider to fetch the deltas from remove server using the host.FileID. But this is now superceded by the fact that pfelf.Reference is passed and the GnuBuildID or other checksums can be calculated if needed.
christos68k
approved these changes
Jul 30, 2025
florianl
approved these changes
Jul 31, 2025
This was referenced Aug 14, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No one uses this. It was originally envisioned to be used for possibly implementing alternative provider to fetch the deltas from remove server using the host.FileID. But this is now superceded by the fact that pfelf.Reference is passed and the GnuBuildID or other checksums can be calculated if needed.