Dockerfile: add ${GOPATH}/bin to $PATH#646
Merged
christos68k merged 2 commits intoopen-telemetry:mainfrom Jul 22, 2025
Merged
Conversation
florianl
reviewed
Jul 22, 2025
| ENV GOPATH="/agent/go" | ||
| ENV GOCACHE="/agent/.cache" | ||
| ENV PATH="/usr/local/go/bin:$PATH" | ||
| ENV PATH="/usr/local/go/bin:/agent/go/bin:$PATH" |
Member
There was a problem hiding this comment.
When testing this change, I noticed, this modification of PATH only does have an effect for the creation of the docker image.
If you build and start this docker image, you will notice this by:
# echo $PATH
/usr/local/cargo/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
We might want to update the following line instead:
# Append to /etc/profile for login shells
RUN echo 'export PATH="/usr/local/go/bin:$PATH"' >> /etc/profile
Contributor
Author
There was a problem hiding this comment.
oh, yes, thanks for catching this.
Indeed, I wanted to have the variable in the container not during the build. I will update the change.
florianl
approved these changes
Jul 22, 2025
rockdaboot
approved these changes
Jul 22, 2025
This was referenced Aug 14, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 11, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 11, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using the installed tools, such as porto in the docker dev container