Skip to content

Go modernize#638

Merged
christos68k merged 3 commits intomainfrom
go-modernize
Jul 21, 2025
Merged

Go modernize#638
christos68k merged 3 commits intomainfrom
go-modernize

Conversation

@florianl
Copy link
Copy Markdown
Member

@florianl florianl commented Jul 21, 2025

This is an automated code update using the following command:

$ go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

florianl added 2 commits July 21, 2025 11:27
@florianl
Go: movernize code
23273b5 
This is an automated code update using the following command:

```
$ go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
```

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl
make linter happy
7c73a06 
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested review from a team as code owners July 21, 2025 09:32
fabled
fabled approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fabled fabled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. One stylistic nit.

Comment thread kallsyms/kallsyms.go Outdated
@rockdaboot
Copy link
Copy Markdown
Contributor

rockdaboot commented Jul 21, 2025

It misses these linter findings. Fixing those would allow us to enable the copyloopvar linter.

processmanager/ebpf/ebpf_integration_test.go:56:3: The copy of the 'for' variable "name" can be deleted (Go 1.22+) (copyloopvar)
                name := name
                ^
processmanager/ebpf/ebpf_integration_test.go:57:3: The copy of the 'for' variable "test" can be deleted (Go 1.22+) (copyloopvar)
                test := test
                ^
tracer/ebpf_integration_test.go:201:3: The copy of the 'for' variable "testcase" can be deleted (Go 1.22+) (copyloopvar)
                testcase := testcase
                ^

While is "hidden" behind Go build flags (and modernize doesn't support them), I wonder why modernize only fixes a few intrange occurrences, but by far not all.

rockdaboot
rockdaboot approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nice step forward.

@florianl
fix comment in kallsyms
7aab0a3 
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@christos68k christos68k merged commit d532b33 into main Jul 21, 2025
27 checks passed
@christos68k christos68k deleted the go-modernize branch July 21, 2025 13:55
This was referenced Aug 14, 2025
Closed
Closed
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request Sep 11, 2025
@florianl @gnurizen
Go modernize (open-telemetry#638)
0cb77bf 
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@gnurizen gnurizen mentioned this pull request Sep 11, 2025
Merged
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request Sep 12, 2025
@florianl @gnurizen
Go modernize (open-telemetry#638)
6fde1af 
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@gnurizen gnurizen mentioned this pull request Sep 16, 2025
Merged
@gnurizen gnurizen mentioned this pull request Mar 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabled fabled fabled approved these changes

@christos68k christos68k christos68k approved these changes

+1 more reviewer

@rockdaboot rockdaboot rockdaboot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@florianl @rockdaboot @fabled @christos68k