Skip to content

coredump: remove dummyMaps as unused #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabled merged 1 commit into from
Jul 17, 2025
Merged

coredump: remove dummyMaps as unused #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions tools/coredump/coredump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,12 @@ import (
"time"
"unsafe"

cebpf "github.com/cilium/ebpf"

"go.opentelemetry.io/ebpf-profiler/libpf"
"go.opentelemetry.io/ebpf-profiler/libpf/xsync"
"go.opentelemetry.io/ebpf-profiler/nativeunwind/elfunwindinfo"
"go.opentelemetry.io/ebpf-profiler/process"
pm "go.opentelemetry.io/ebpf-profiler/processmanager"
"go.opentelemetry.io/ebpf-profiler/reporter"
"go.opentelemetry.io/ebpf-profiler/support"
tracertypes "go.opentelemetry.io/ebpf-profiler/tracer/types"
)

Expand Down Expand Up @@ -136,17 +133,6 @@ func ExtractTraces(ctx context.Context, pr process.Process, debug bool,
debugFlag = 1
}

dummyMaps := make(map[string]*cebpf.Map)
for _, mapName := range []string{"interpreter_offsets",
"pid_page_to_mapping_info", "stack_delta_page_to_info", "pid_page_to_mapping_info",
"dotnet_procs", "perl_procs", "py_procs", "hotspot_procs", "ruby_procs",
"php_procs", "v8_procs"} {
dummyMaps[mapName] = &cebpf.Map{}
}
for i := support.StackDeltaBucketSmallest; i <= support.StackDeltaBucketLargest; i++ {
dummyMaps[fmt.Sprintf("exe_id_to_%d_stack_deltas", i)] = &cebpf.Map{}
}

// In host agent we have set the default value for monitorInterval to 5 seconds. But as coredump
// nor the tests that are calling ExtractTraces() are initializing the reporter package we want
// to set monitorInterval to a higher value.
Expand Down