coredump: enable cgo warnings#613
Merged
fabled merged 27 commits intoopen-telemetry:mainfrom Jul 30, 2025
Merged
Conversation
korniltsev
force-pushed
the
korniltsev/coredump_warnings
branch
from
a013733 to
e88a47c
Compare
korniltsev
commented
Jul 17, 2025
korniltsev
commented
Jul 17, 2025
korniltsev
commented
Jul 17, 2025
korniltsev
commented
Jul 17, 2025
| #cgo CFLAGS: -Wno-unused-label | ||
| #cgo CFLAGS: -Wno-sign-compare | ||
| #cgo CFLAGS: -Wno-unknown-pragmas | ||
| #cgo CFLAGS: -Wno-unused-parameter |
Contributor
Author
There was a problem hiding this comment.
Unfortunately can not enable this one in cgo because of golang/go#71225
Contributor
Author
There was a problem hiding this comment.
# go.opentelemetry.io/ebpf-profiler/tools/coredump
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___bpf_log':
cgo-generated-wrappers:91:43: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___push_frame':
cgo-generated-wrappers:92:46: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03_bpf_ktime_get_ns':
cgo-generated-wrappers:93:50: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03_bpf_get_current_comm':
cgo-generated-wrappers:94:54: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___bpf_probe_read_user':
cgo-generated-wrappers:95:55: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___bpf_map_lookup_elem':
cgo-generated-wrappers:96:55: error: unused parameter 'p' [-Werror=unused-parameter]
cc1: all warnings being treated as errors
florianl
reviewed
Jul 17, 2025
This reverts commit 2174352.
korniltsev
force-pushed
the
korniltsev/coredump_warnings
branch
from
87e233e to
b8e751b
Compare
florianl
approved these changes
Jul 21, 2025
rockdaboot
reviewed
Jul 21, 2025
Comment on lines
+109
to
+111
| #if !defined(TESTING_COREDUMP) | ||
| #pragma unroll 256 | ||
| #endif |
Contributor
There was a problem hiding this comment.
Avoid code repetition by defining a macro (e.g. UNROLL), which is empty for gcc.
Just in case, https://github.com/open-telemetry/opentelemetry-ebpf-profiler/pull/613/files#r2218507693 can't be solved to use the same compiler everywhere.
Contributor
Author
There was a problem hiding this comment.
Applied, please take a look.
rockdaboot
approved these changes
Jul 21, 2025
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
Thanks for working on this, LGTM
christos68k
reviewed
Jul 25, 2025
korniltsev
force-pushed
the
korniltsev/coredump_warnings
branch
from
8ffbb79 to
a21ac05
Compare
christos68k
approved these changes
Jul 28, 2025
fabled
reviewed
Jul 28, 2025
Comment on lines
+186
to
+188
| #define _PRAGMA_UNROLL(x) _Pragma(_STR(unroll x)) | ||
| // Macro for loop unrolling. Expands to the appropriate pragma for clang. | ||
| #define UNROLL(N) _PRAGMA_UNROLL(N) |
Contributor
There was a problem hiding this comment.
could we just?
Suggested change
| #define _PRAGMA_UNROLL(x) _Pragma(_STR(unroll x)) | |
| // Macro for loop unrolling. Expands to the appropriate pragma for clang. | |
| #define UNROLL(N) _PRAGMA_UNROLL(N) | |
| // Macro for loop unrolling. Expands to the appropriate pragma for clang. | |
| #define UNROLL _Pragma(unroll 256) |
the number is maximum unrolled loops, and the largest is in dotnet, so we can use 256 unconditionally.
Contributor
There was a problem hiding this comment.
We could then just write on all instances UNROLL for () (keep UNROLL on same line with for).
Contributor
Author
There was a problem hiding this comment.
I don't necessarily like the idea to write UNROLL for on the same line, but lets try and see how it looks and what others think
Contributor
Author
There was a problem hiding this comment.
clang-format seem to be happy with it
korniltsev
force-pushed
the
korniltsev/coredump_warnings
branch
from
6f7504a to
1cc7b66
Compare
This was referenced Aug 14, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 11, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 11, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 12, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wunused-parameterin the ebpf makefile(void).