Conversation
florianl
commented
Jul 11, 2025
|
|
||
| // Remove entry from the map so the stack for the same pid_tgid does not get unwound and | ||
| // reported accidentally without the start timestamp updated in tracepoint/sched/sched_switch. | ||
| bpf_map_delete_elem(&sched_times, &pid_tgid); |
Member
Author
There was a problem hiding this comment.
Note: We can not use bpf_map_lookup_and_delete_elem (introduced with Kernel 4.20) here, as this is a user space helper, that is not available as eBPF helper.
Make sure the stack is not unwound multiple times for the same pid_tgid with the same start time. Fixes #593 Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
approved these changes
Jul 11, 2025
fabled
approved these changes
Jul 11, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the stack is not unwound multiple times for the same pid_tgid with the same start time.
Fixes #593