Skip to content

ci: fix cron job for auto tagging#574

Merged
christos68k merged 3 commits intomainfrom
florianl-patch-1
Jul 1, 2025
Merged

ci: fix cron job for auto tagging#574
christos68k merged 3 commits intomainfrom
florianl-patch-1

Conversation

@florianl
Copy link
Copy Markdown
Member

@florianl florianl commented Jul 1, 2025

Fix the trigger for the auto tagging job. At the moment it would run on every day of January instead of every 1st of each month.

Here is the format:

┌───────────── minute (0 - 59)
│ ┌───────────── hour (0 - 23)
│ │ ┌───────────── day of the month (1 - 31)
│ │ │ ┌───────────── month (1 - 12 or JAN-DEC)
│ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT)
│ │ │ │ │
* * * * *

Fix the trigger for the auto tagging job. At the moment it would run on every day of January instead of every 1st of each month.

Here is the format:

```
┌───────────── minute (0 - 59)
│ ┌───────────── hour (0 - 23)
│ │ ┌───────────── day of the month (1 - 31)
│ │ │ ┌───────────── month (1 - 12 or JAN-DEC)
│ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT)
│ │ │ │ │
│ │ │ │ │
│ │ │ │ │
*  *  *  *  *
```
@florianl florianl requested review from a team as code owners July 1, 2025 12:14
# Run every month on the 1st day at 08:15 AM.
- cron: '15 8 * 1 *'
# Run every month on the 3rd day at 08:15 AM.
- cron: '15 8 3 * *'
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the schedule from the 1st of the month to 3rd of the month, as I hope this fix gets approved and merged, before this possible next schedule and we see it in action.
And as we are supposed to provide a tagged version for OTel collector release, tagging should happen rather soonish.

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jul 1, 2025

@florianl
Copy link
Copy Markdown
Member Author

florianl commented Jul 1, 2025

How about adding a workflow_dispatch [..]

I was looking into this, but couldn't find a proper way to limit it to a user group. Ideally only maintainers (or approvers) of the project should be able to trigger a workflow_dispatch run to tag a new version. As I didn't find anything around authorization for this kind of trigger, I did not add it.

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jul 1, 2025

Only folks with write permissions should be able to trigger a workflow.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl
Copy link
Copy Markdown
Member Author

florianl commented Jul 1, 2025

Only folks with write permissions should be able to trigger a workflow.

I wasn't aware of that and obviously didn't find any documentation around it. Added the manual trigger with 08dfef9.

@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jul 1, 2025

From the doc above:

Write access to the repository is required to perform these steps.

@christos68k christos68k merged commit cf9fef0 into main Jul 1, 2025
25 checks passed
@christos68k christos68k deleted the florianl-patch-1 branch July 1, 2025 13:52
@florianl
Copy link
Copy Markdown
Member Author

florianl commented Jul 1, 2025

Thanks @christos68k for merging.
While I don't have permissions to merge PRs, I seem to have permissions to trigger workflows:
https://github.com/open-telemetry/opentelemetry-ebpf-profiler/actions/runs/16001613612

In other words - please cheer for our first tag: https://github.com/open-telemetry/opentelemetry-ebpf-profiler/tags

@rockdaboot
Copy link
Copy Markdown
Contributor

In other words - please cheer for our first tag: https://github.com/open-telemetry/opentelemetry-ebpf-profiler/tags

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants