elfehframe: dynamically detect entry stub#573
Merged
fabled merged 4 commits intoopen-telemetry:mainfrom Jul 2, 2025
Merged
Conversation
fabled
force-pushed
the
musl-amd64-entry
branch
2 times, most recently
from
8508db2 to
c4bde22
Compare
fabled
changed the title
fabled
force-pushed
the
musl-amd64-entry
branch
2 times, most recently
from
93f4eea to
469ecb5
Compare
Earlier we synthesized STOP delta for FDE ending at the entry point. This does not work reliably: 1. in some cases there is no FDE preceding the entry point and 2. often the musl entry code's second portion of code immediately following the CALL which has an FDE that will invalidate the STOP delta. To better handle the situation this will dynamically match the entry code against known stubs when needed and mark the whole stub with STOP overriding any FDEs.
christos68k
approved these changes
Jul 1, 2025
florianl
reviewed
Jul 2, 2025
Member
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
Great to see these error frame gone 😅
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier we synthesized STOP delta for FDE ending at the entry point. This does not work reliably: 1. in some cases there is no FDE preceding the entry point and 2. often the musl entry code's second portion of code immediately following the CALL which has an FDE that will invalidate the STOP delta.
To better handle the situation this will dynamically match the entry code against known stubs when needed and mark the whole stub with STOP overriding any FDEs.