Improve elfehframe handling#564
Merged
fabled merged 5 commits intoopen-telemetry:mainfrom Jul 2, 2025
Merged
Conversation
Give the information via a ehframeHooks instead. This information does not belong in the fdeInfo.
- minor improvements and bug fixes - remove restriction on concurrency
fabled
force-pushed
the
elfehframe-cleanup
branch
from
3d515cd to
4d2e214
Compare
christos68k
reviewed
Jun 27, 2025
christos68k
approved these changes
Jul 1, 2025
Comment on lines
+90
to
+92
| if ee.ref == nil { | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
Do we need this check? Looking at the current code I don't see a case where ee.ref will ever be nil.
If there is such a case, maybe it makes sense to lift this check higher in the call stack to avoid getting to this point.
Suggested change
| if ee.ref == nil { | |
| return nil | |
| } |
Contributor
Author
There was a problem hiding this comment.
There is a test case that sets elf reference to nil. I'll relocate this test.
florianl
approved these changes
Jul 2, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sortedout fromfdeInfoas it does not belong there