interpreter/go: fix referencing mmap area after unload#561
Merged
fabled merged 1 commit intoopen-telemetry:mainfrom Jun 27, 2025
Merged
interpreter/go: fix referencing mmap area after unload#561fabled merged 1 commit intoopen-telemetry:mainfrom
fabled merged 1 commit intoopen-telemetry:mainfrom
Conversation
The goData Unload should not releace the pclntab until all goInstances are Detached. Otherwise a Symbolize call can be done with the pclntab released. Additionally, intern the strings from pclntab lookups using unique to not leak mmapped data referencing string outside this module. fixes open-telemetry#557
christos68k
approved these changes
Jun 27, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goData Unload should not releace the pclntab until all goInstances are Detached. Otherwise a Symbolize call can be done with the pclntab released.
Additionally, intern the strings from pclntab lookups using unique to not leak mmapped data referencing string outside this module.
fixes #557