offcpu: Fix incorrect OffTimes values in offcpu profiling.#559
Merged
christos68k merged 1 commit intoopen-telemetry:mainfrom Jul 3, 2025
Merged
offcpu: Fix incorrect OffTimes values in offcpu profiling.#559christos68k merged 1 commit intoopen-telemetry:mainfrom
christos68k merged 1 commit intoopen-telemetry:mainfrom
Conversation
florianl
approved these changes
Jun 30, 2025
rockdaboot
reviewed
Jun 30, 2025
rockdaboot
reviewed
Jun 30, 2025
tsint
force-pushed
the
offcpu
branch
2 times, most recently
from
7f89426 to
30aa4f9
Compare
Contributor
|
The changes LGTM! Can you possibly create a test function? but stripped down, as it only needs to check for correct profile.Duration and profile.StartTime. Ideally have a test case with two samples and unsorted timestamp values. |
florianl
approved these changes
Jun 30, 2025
Contributor
Author
Okay, I'll look into it. |
tsint
force-pushed
the
offcpu
branch
4 times, most recently
from
db18b92 to
fb0482e
Compare
rockdaboot
reviewed
Jun 30, 2025
rockdaboot
approved these changes
Jun 30, 2025
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
Thank you for finding the issue and fixing it!
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, while sorting the samples by timestamp, the corresponding offcpu profiling values were not sorted accordingly, leading to incorrect samples mappings and overlapping offcpu time intervals.