Update linter#507
Merged
christos68k merged 7 commits intoopen-telemetry:mainfrom Jun 11, 2025
Merged
Conversation
Member
|
Instead of ever changing various places, I would love if we can wait for a moment, until the minimum supported Go version is Go 1.24. Example: This allows to slim and simplify things in a lot of places. |
Contributor
Author
That possibly a good thing. But can we make this two steps? So get this PR in and whenever we switch to 1.24 and someone has the time, do what you suggest? |
christos68k
approved these changes
Jun 5, 2025
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
florianl
reviewed
Jun 6, 2025
florianl
approved these changes
Jun 10, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
golangci-lintrequired to rewrite parts of the config filelintto use docker (building with go is no longer supported with v2)make lintin the CI to keep it in sync with local linting (less maintenance)nolintdirectives as some linters are no longer available