chore(deps): update golangci/golangci-lint-action action to v8#499
chore(deps): update golangci/golangci-lint-action action to v8#499renovate[bot] wants to merge 1 commit intomainfrom
Conversation
| run: (echo -n "version="; make linter-version) >> "$GITHUB_OUTPUT" | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6 | ||
| uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 |
There was a problem hiding this comment.
This conflicts with our Makefile:
opentelemetry-ebpf-profiler/Makefile
Line 86 in 2a2d56b
There was a problem hiding this comment.
Automatically updating golangci-lint is possibly not a good idea, as new version may introduce new linters with positives, which require manual fixes.
I'd suggest to use make lint in the CI and update the linter version in the Makefile every now and then (e.g. with every new minor Go version).
There was a problem hiding this comment.
That would also fix the "out-of-sync" situation with CI and Makefile.
There was a problem hiding this comment.
How does disabling updates on golangci-lint by renovate sound to you?
There was a problem hiding this comment.
That's OK as a quick fix.
Maybe in a separate PR: Add a CI step calling make lint
renovate
Bot
force-pushed
the
renovate/major-github-actions
branch
from
7e09ffd to
2a61748
Compare
Follow up to #499 (comment). As automatic updates of the CI action golangci-lint-action conflicts with other parts, ignore this dependency. Also set `automerge` for groups that will not break things. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
|
Closing this PR in favor of #506. |
2 participants
This PR contains the following updates:
v6.5.2->v8.0.0Release Notes
golangci/golangci-lint-action (golangci/golangci-lint-action)
v8.0.0Compare Source
Requires
golangci-lintversion >=v2.1.0What's Changed
Changes
Full Changelog: golangci/golangci-lint-action@v7...v8.0.0
v7.0.1Compare Source
What's Changed
Documentation
Dependencies
New Contributors
Full Changelog: golangci/golangci-lint-action@v7.0.0...v7.0.1
v7.0.0Compare Source
What's Changed
Changes
Documentation
Dependencies
New Contributors
Full Changelog: golangci/golangci-lint-action@v6.5.2...v7.0.0
Configuration
📅 Schedule: Branch creation - "before 8am every weekday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.