Skip to content

Fix metrics test (timing-based interference) #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christos68k merged 1 commit into from
Jun 2, 2025
Merged

Fix metrics test (timing-based interference) #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,11 @@ func init() {
}
}

// report converts and reports collected metrics via OTel metrics
func report() {
// report converts and reports collected metrics via OTel metrics.
// Allow for report to be overridden in the test.
var report = func() {
ctx := context.Background()
for i := 0; i < nMetrics; i++ {
for i := range nMetrics {
metric := metricsBuffer[i]
switch typ := metricTypes[metric.ID]; typ {
case MetricTypeCounter:
Expand Down
3 changes: 3 additions & 0 deletions metrics/metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ import (

// TestMetrics
func TestMetrics(t *testing.T) {
// NOP report to avoid timing-based interference.
report = func() {}

inputMetrics := []Metric{
{IDELFInfoCacheHit, MetricValue(33)},
{IDELFInfoCacheMiss, MetricValue(55)},
Expand Down