chore(deps): pin dependencies#473
Merged
christos68k merged 1 commit intomainfrom May 30, 2025
Merged
Conversation
christos68k
reviewed
May 30, 2025
| name: Check for differences in the eBPF and Rust binary blobs | ||
| runs-on: ubuntu-24.04 | ||
| container: otel/opentelemetry-ebpf-profiler-dev:latest | ||
| container: otel/opentelemetry-ebpf-profiler-dev:latest@sha256:688e4651a9a482700836ff59ea00270b2c237bbcb2cf6b6c9daffcf29fa0a0cb |
Member
There was a problem hiding this comment.
We probably shouldn't pin this?
Member
There was a problem hiding this comment.
While it's considered best practice to pin dependencies in CI to their hash, I agree that the benefit here might be limited. It adds one additional step for us, if we update the image.
On the other hand, anyone with the correct permissions is able to overwrite this image atm and as we just use latest instead of a version, this might will help us identify such scenarios more easily.
florianl
approved these changes
May 30, 2025
christos68k
approved these changes
May 30, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5a3ec8411bd719d3f86a1d35c59aea165f82ed89b1263435374a5d14b5ca5142910929ff0a06e55c2c14688e465Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.