reporter: fix race condition in FrameKnown#471
Merged
christos68k merged 1 commit intoopen-telemetry:mainfrom May 28, 2025
Merged
reporter: fix race condition in FrameKnown#471christos68k merged 1 commit intoopen-telemetry:mainfrom
FrameKnown#471christos68k merged 1 commit intoopen-telemetry:mainfrom
Conversation
4377c74 switched the inner value of `pdata.Frames` to be a LRU, instead of a map. It uses `GetAndRefresh` in `FrameKnown` to update the lifetime of an element, if it exists. `GetAndRefresh` is a write operation, but the lock that is taken around this operation was not updated in the commit, thus we still only hold a read lock here, leading to potential data races. This commit changes the code to take a write lock instead, so only one Goroutine can refresh the key at a time.
The committers listed above are authorized under a signed CLA. |
athre0z
approved these changes
May 28, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4377c74 switched the inner value of
pdata.Framesto be a LRU, instead of a map. It usesGetAndRefreshinFrameKnownto update the lifetime of an element, if it exists.GetAndRefreshis a write operation, but the lock that is taken around this operation was not updated in the commit, thus we still only hold a read lock here, leading to potential data races.This commit changes the code to take a write lock instead, so only one Goroutine can refresh the key at a time.