Fix data race in MaybeNotifyAPMAgent#469
Merged
fabled merged 1 commit intoopen-telemetry:mainfrom May 26, 2025
Merged
Conversation
`MaybeNotifyAPMAgent` could previously access the interpreter map while it was being updated in another goroutine during PID event processing.
MaybeNotifyAPMAgent
florianl
approved these changes
May 26, 2025
rockdaboot
approved these changes
May 26, 2025
fabled
approved these changes
May 26, 2025
Member
Author
|
@fabled can you please merge? It seems that approvers no longer have permissions to do so themselves. |
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaybeNotifyAPMAgentcould previously access the interpreter map while it was being updated in another goroutine during PID event processing. This commit correctly takes the lock to prevent this in the future.This doesn't happen much during normal operation, but becomes increasingly likely with higher sampling rates.
Example crash