Conversation
Currently the agent produces log lines that contains paths like this: /proc/52627/root//usr/sbin/runc Use path.Join() to avoid double // in paths. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
fabled
approved these changes
Apr 7, 2025
Contributor
fabled
left a comment
fabled
left a comment
There was a problem hiding this comment.
LGTM with question on the path component string style to use if the slashes should be there or not? My personal preference is slightly on not including the slash unless needed. Thoughts?
Approving in any case.
Co-authored-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
reviewed
Apr 7, 2025
rockdaboot
reviewed
Apr 7, 2025
rockdaboot
approved these changes
Apr 7, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the agent produces log lines that contains paths like this:
/proc/52627/root//usr/sbin/runc
Use path.Join() to avoid double // in paths.