Skip to content

coredump: use path.Join in the 'new' command#430

Merged
fabled merged 1 commit intoopen-telemetry:mainfrom
fabled:coredump-path-join
Apr 6, 2025
Merged

coredump: use path.Join in the 'new' command#430
fabled merged 1 commit intoopen-telemetry:mainfrom
fabled:coredump-path-join

Conversation

@fabled
Copy link
Copy Markdown
Contributor

@fabled fabled commented Apr 4, 2025

No description provided.

Signed-off-by: Timo Teräs <timo.teras@iki.fi>
@fabled fabled requested review from a team as code owners April 4, 2025 04:03
@fabled
Copy link
Copy Markdown
Contributor Author

fabled commented Apr 4, 2025

arm failed due to unrelated metrics test change:

--- FAIL: TestMetrics (0.02s)
    metrics_test.go:37: 
        	Error Trace:	/home/runner/work/opentelemetry-ebpf-profiler/opentelemetry-ebpf-profiler/metrics/metrics_test.go:37
        	Error:      	Not equal: 
        	            	expected: []metrics.Metric{metrics.Metric{ID:0x54, Value:33}, metrics.Metric{ID:0x55, Value:55}, metrics.Metric{ID:0x9d, Value:66}, metrics.Metric{ID:0x9c, Value:20}}
        	            	actual  : []metrics.Metric{metrics.Metric{ID:0x9d, Value:66}, metrics.Metric{ID:0x9c, Value:20}, metrics.Metric{ID:0x54, Value:33}, metrics.Metric{ID:0x55, Value:55}}

Seems this is just ordering issue in the array. Git blame tells this was last changed in commit c6cb9d4. @christos68k any ideas?

@christos68k
Copy link
Copy Markdown
Member

christos68k commented Apr 4, 2025

Seems this is just ordering issue in the array. Git blame tells this was last changed in commit c6cb9d4. @christos68k any ideas?

Ignore it and merge as normal, I'll look into it and open a PR to fix it. It's probably a timing issue due to CPU load causing processing delay and report() getting called in-between Add* calls as the 1-second processing window is exceeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants