Skip to content

Add pfelf support for go version detection#424

Merged
rockdaboot merged 5 commits intoopen-telemetry:mainfrom
parca-dev:go-vers
Apr 3, 2025
Merged

Add pfelf support for go version detection#424
rockdaboot merged 5 commits intoopen-telemetry:mainfrom
parca-dev:go-vers

Conversation

@gnurizen
Copy link
Copy Markdown
Contributor

@gnurizen gnurizen commented Apr 1, 2025

No description provided.

@gnurizen gnurizen marked this pull request as ready for review April 1, 2025 08:39
@gnurizen gnurizen requested review from a team as code owners April 1, 2025 08:39
Comment thread libpf/pfelf/file.go Outdated
Comment thread libpf/pfelf/file.go Outdated
Copy link
Copy Markdown
Contributor

@fabled fabled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise. Few nits on comments only.

Comment thread libpf/pfelf/file.go Outdated
Comment thread libpf/pfelf/file.go Outdated
Comment thread libpf/pfelf/testdata/Makefile
@rockdaboot rockdaboot merged commit a68ddad into open-telemetry:main Apr 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants