LuaJIT language unwinder#419
Closed
gnurizen wants to merge 4 commits into
Closed
Conversation
Contributor
gnurizen
commented
Mar 24, 2025
gnurizen
commented
- Go custom labels from pprof labels
- Use gotoolchain instead of github matrix strategy
- Native custom labels
- LuaJIT unwinding support for openresty 1.15+
Add support for a collection of 10 labels that can be attached to every sample. Process the go pprof labels into these labels. Test that this works for Go 1.23 and Go 1.24 with new kernel tests. Co-authored-by: umanwizard <brennan@umanwizard.com>
If a process links against the custom labels library: https://github.com/polarsignals/custom-labels Or is statically linked and has the custom_labels_abi_version exported symbol then we will try to read custom labels out of the TLS name 'custom_labels_current_set'. Co-authored-by: umanwizard brennan@umanwizard.com
Contributor
|
Seems this needs a rebase. And contains multiple features in single PR. Perhaps you can rebase and make this LuaJIT -only PR? Please ping me if when its ready for a pre-review. Thanks! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.