reporter: simplify TraceReporter interface#405
Merged
christos68k merged 6 commits intomainfrom Mar 28, 2025
Merged
Conversation
This proposed change implements #384 (comment) as a first step of #384. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
reviewed
Mar 17, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
reviewed
Mar 19, 2025
Comment on lines
+109
to
+110
| // Wait to make sure the purge routine did start. | ||
| wg.Wait() |
Contributor
There was a problem hiding this comment.
Does it make sense to wait here? It doesn't harm if the go routine starts after return.
Member
Author
There was a problem hiding this comment.
The waitgroup pattern is just used to make sure the Go routine starts. This pattern is used also in other places in the code base. Waiting here should not increase the start up time in a noticeable way. But as we can not control the Go scheduler, we make sure this way, the clean up/purge routine is working properly and scheduled.
rockdaboot
approved these changes
Mar 19, 2025
christos68k
reviewed
Mar 19, 2025
Member
christos68k
left a comment
christos68k
left a comment
There was a problem hiding this comment.
I'll do another pass and test a bit.
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
rockdaboot
reviewed
Mar 20, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
christos68k
approved these changes
Mar 28, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Mar 31, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Apr 1, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Apr 1, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Apr 1, 2025
This was referenced Apr 4, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Apr 16, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Apr 18, 2025
This was referenced Apr 23, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
Apr 30, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
May 5, 2025
nsavoire
added a commit
to DataDog/dd-otel-host-profiler
that referenced
this pull request
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposed change implements #384 (comment) as a first step of #384.