Skip to content

tracehandler: drop metadataWarnInhib #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianl merged 1 commit into from
Mar 7, 2025
Merged

tracehandler: drop metadataWarnInhib #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions tracehandler/tracehandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ import (
"go.opentelemetry.io/ebpf-profiler/reporter"
)

// metadataWarnInhibDuration defines the minimum duration between warnings printed
// about failure to obtain metadata for a single PID.
const metadataWarnInhibDuration = 1 * time.Minute

// Compile time check to make sure config.Times satisfies the interfaces.
var _ Times = (*times.Times)(nil)

Expand Down Expand Up @@ -77,10 +73,6 @@ type traceHandler struct {
// reporter instance to use to send out traces.
reporter reporter.TraceReporter

// metadataWarnInhib tracks inhibitions for warnings printed about failure to
// update container metadata (rate-limiting).
metadataWarnInhib *lru.LRU[libpf.PID, libpf.Void]

times Times
}

Expand All @@ -99,19 +91,12 @@ func newTraceHandler(rep reporter.TraceReporter, traceProcessor TraceProcessor,
return nil, err
}

metadataWarnInhib, err := lru.New[libpf.PID, libpf.Void](64, libpf.PID.Hash32)
if err != nil {
return nil, fmt.Errorf("failed to create metadata warning inhibitor LRU: %v", err)
}
metadataWarnInhib.SetLifetime(metadataWarnInhibDuration)

t := &traceHandler{
traceProcessor: traceProcessor,
bpfTraceCache: bpfTraceCache,
umTraceCache: umTraceCache,
reporter: rep,
times: intervals,
metadataWarnInhib: metadataWarnInhib,
traceProcessor: traceProcessor,
bpfTraceCache: bpfTraceCache,
umTraceCache: umTraceCache,
reporter: rep,
times: intervals,
}

return t, nil
Expand Down